2
Vote

Zone bug

description

MiniProfiler adds a shape to either the Footer zone or the Head zone in case the former does not exist.
However, the current code does not work as expected, because if the Footer zone is not defined, it will not evaluate to NULL when using the null-coalesce operator. Instead, it will evaluate to some empty shape object - not the Head zone.

To fix this, in the ProfilerFilter.OnResultExecuting method, change this line:
var place = workContext.Layout.Footer ?? workContext.Layout.Head;
To this:
var place = workContext.Layout.Footer != null ? workContext.Layout.Footer : workContext.Layout.Head;
And ignore ReSharper. ;)

comments